Prevent remediation when assignment_enforcement_mode=false

[pmatthews05]

Description

• When a assignment (initiative or definition) is set, and the assignment_enforcement_mode is set to false, it shouldn't apply a remediation. An extra condition to check for this assignment_enforcement_mode.
• For data calls to azurerm_policy_set_definition change calls to lookup from name, as Microsoft changes display names, update examples, and readme files.
• Switch data.azurerm_policy_definition to data.azurerm_policy_definition_built_in and using the name instead of the display name. Updated examples and readme files.
• Updated azurerm version number to >=3.44.0 in examples and readme files, because data.azurerm_policy_definition_built_in is only available from that version onwards.
• Formatted the tf files, using newly created script .\format-terraform.ps1

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Test Configuration:

• Module Version: Latest
• Terraform Version: 1.4.4 on Windows_amd64
• AzureRM Provider Version: 3.5.0

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked my code and corrected any misspellings

[gettek]

Hi @pmatthews05, thank you for raising this, great spot about preventing remediation when assignment_enforcement_mode=false.

Could you kindly update your branch with the changes made in #73, have finally caved into running terraform fmt on all modules since noticing this PR, have also modified the existing pre-commit script so we can remove format-terraform.ps1

[pmatthews05]

@gettek I have pulled your code into mine using a separate branch. Went through all the conflicts. I then merged this branch into my main.
That should make this PR correct now, with no merge conflicts and has both #73 and #74.

[pmatthews05]

@gettek I see you have added some tags and assigned to me. Is there anything else you require for me to do?

[gettek]

@pmatthews05 looking forward to merge this but made a few comments above if you wouldn't mind resolving first please?

[pmatthews05]

@gettek are the comments you referring to the following?

Could you kindly update your branch with the changes made in #73, have finally caved into running terraform fmt on all modules since noticing this PR, have also modified the existing pre-commit script so we can remove format-terraform.ps1

If so, I have updated my code with the changes made in #73, and removed format-terraform.ps1. You should se the 5 commits I made after that comment to complete what you requested.

If it's something else, please let me know.

[gettek]

@pmatthews05 if you scroll through the file changes (or above) I have made a few more comments for minor changes 🙂

[pmatthews05]

@gettek I'm sorry, I've looked at file changes and there are no comments from you for minor changes. Do you mind re-listing them in a comment back to me please?

[gettek]

@pmatthews05 apologies, forgot to hit the submit review button!

[gettek]

Thanks @pmatthews05 - Please fix the final comment and run precommit to update the readme's back to the old tf versioning