This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Base64 password to bypass passport issue #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to be implemented on the manager side, because otherwise users won't be able to login after an update |
Sure thing! I will add it tomorrow |
This was referenced Feb 7, 2021
|
Just for reference, corresponding Passport issue is here: jaredhanson/passport-http#20 It's been open since 2014! |
|
|
Closed by getumbrel/umbrel-manager#78 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolve getumbrel/umbrel#424
The passwords are transformed in b64 with btoa to bypass the Passport issue who's splitting passwors with colon
Linked to getumbrel/umbrel-manager#76
Linked to getumbrel/umbrel-middleware#79
Thx @louneskmt @AaronDewes for the base64 tip