Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to define Sidekiq sender class #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jylamont
Copy link
Contributor

@jylamont jylamont commented Nov 1, 2015

This is one possible solution to #51 and #54. Essentially you can define your own SidekiqWorker class to send API requests to Vero.

Something like this...

class MyVeroSidekiqWorker < Vero::SidekiqWorker
   sidekiq_options retry: 2, queue: 'another_queue'
   sidekiq_retry_in { |count| 60 }
end

and in vero.rb

Vero::App.init do |config|
   # ...
   config.sender_class = MyVeroSidekiqWorker
end

What do you think @damienbrz, @shaneog, @lemboy, @criticerz?

@lemboy
Copy link

lemboy commented Nov 2, 2015

Yes, we did something like this - added possible use custom sidekiq worker #56.

@shaneog
Copy link
Contributor

shaneog commented Nov 2, 2015

I like it. It's cleaner than the current monkey patching I'm doing.

Now, if we could remove the hard dependency on sucker_punch it would be great 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants