[FTP-1778][PHP81] Fix PHP 8.1 types #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboos
reviewed
Jan 23, 2023
| return $this; | ||
| } | ||
|
|
||
| protected function hacklib_isImmutable() { | ||
| protected function hacklib_isImmutable() |
There was a problem hiding this comment.
No return type on this and immutable()? Same on the other hacklib_imm ones.
There was a problem hiding this comment.
While we can add it, it's not strictly required for PHP 8.1. I wanna change as little as it's strictly required here. We're slowly deprecating thrift, so don't wanna spend too much effort here.
pboos
reviewed
Jan 23, 2023
| @@ -24,23 +24,27 @@ trait HACKLIB_ImmVectorLike { | |||
| /** | |||
| * identical to at, implemented for ArrayAccess | |||
| */ | |||
| public function offsetGet($offset) { | |||
| public function offsetGet($offset) | |||
There was a problem hiding this comment.
This is mixed, which is a keyword added only in php 8. We can add attribute #ReturnTypeWillChange actually.
pboos
reviewed
Jan 23, 2023
| $this->remove($offset); | ||
| } | ||
|
|
||
| /** | ||
| * Adds an element to this Set and returns itself. "$c->add($v)" is | ||
| * equivalent to "$c[] = $v" (except that add() returns the Set). | ||
| */ | ||
| public function add($v) { | ||
| public function add($v) |
There was a problem hiding this comment.
It's not defined in the interface. I won't add what's not strictly necessary for PHP 8.1
pboos
reviewed
Jan 23, 2023
| @@ -24,26 +24,29 @@ trait HACKLIB_VectorLike { | |||
| /** | |||
| * identical to at, implemented for ArrayAccess | |||
| */ | |||
| public function &offsetGet($offset) { | |||
| public function &offsetGet($offset) | |||
There was a problem hiding this comment.
Added the ReturnTypeWillChange attribute.
pboos
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTP-1778 Fix types for PHP 8
https://sentry.io/organizations/getyourguide/issues/3881940091/?project=5719417&referrer=assigned_activity-email