Skip to content

bugfix: on exception log 500 status code instead of 200 status code #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 22, 2023
Merged

bugfix: on exception log 500 status code instead of 200 status code #65

merged 20 commits into from
Nov 22, 2023

Conversation

@pboos
Copy link
Contributor

@pboos pboos commented Nov 22, 2023

  1. Fix exception handling to report 500 status code instead of 200 status code (done here)
    • This required switching to Filter & Interceptor to improve the handling and being able to get the actual exception
  2. Add integration tests

@pboos pboos marked this pull request as ready for review November 22, 2023 11:52
@pboos pboos requested a review from a team as a code owner November 22, 2023 11:52
@pboos pboos requested a review from huguenin November 22, 2023 11:52
@pboos pboos changed the title Bugfix/exception handling bugfix: on exception log 500 status code instead of 200 status code Nov 22, 2023
eleonoraborghi
eleonoraborghi approved these changes Nov 22, 2023
View reviewed changes
Copy link

@eleonoraborghi eleonoraborghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure I fully understand all... but the part I do looks good!!!

@pboos pboos merged commit 0055dd4 into main Nov 22, 2023
@pboos pboos deleted the bugfix/exception-handling branch November 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huguenin huguenin Awaiting requested review from huguenin huguenin is a code owner automatically assigned from getyourguide/chk

1 more reviewer

@eleonoraborghi eleonoraborghi eleonoraborghi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pboos @eleonoraborghi