Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load env in helper file #196

Merged
merged 2 commits into from
Oct 22, 2024
Merged

load env in helper file #196

merged 2 commits into from
Oct 22, 2024

Conversation

prasmussen15
Copy link
Collaborator

@prasmussen15 prasmussen15 commented Oct 22, 2024

Make sure DEFAULT_DATABASE actually gets loaded


Important

Adds load_dotenv() in helpers.py to load environment variables, ensuring DEFAULT_DATABASE is set, and updates version to 0.3.15.

  • Environment Loading:
    • Adds load_dotenv() in helpers.py to load environment variables.
    • Ensures DEFAULT_DATABASE is set from environment variables.
  • Version Update:
    • Bumps version in pyproject.toml from 0.3.14 to 0.3.15.

This description was created by Ellipsis for 4e24d9b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9e8e990 in 9 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. graphiti_core/helpers.py:24
  • Draft comment:
    Loading environment variables with load_dotenv() at the module level can lead to unintended side effects if this module is imported elsewhere. Consider encapsulating it in a function or a conditional block to control when it's executed.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The use of load_dotenv() at the top level of the module can have unintended side effects, especially if this module is imported elsewhere. It's better to encapsulate it in a function or a conditional block.
2. graphiti_core/helpers.py:18
  • Draft comment:
    Function names should follow a consistent naming pattern. Consider using snake_case for all function names, e.g., parse_db_date and normalize_l2. This comment applies to all function names in this file.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function names are not following a consistent pattern. Some use underscores while others do not.

Workflow ID: wflow_oaJDRagny2GOFLDr


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4e24d9b in 8 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:3
  • Draft comment:
    The version bump to 0.3.15 is noted, but the actual code change to load environment variables is not visible in this diff. Ensure that load_dotenv() is correctly added in helpers.py as described in the PR.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The version bump in the pyproject.toml file is consistent with the PR description, which mentions a change to ensure DEFAULT_DATABASE is loaded from environment variables. However, the actual code change related to loading environment variables is not visible in the diff provided. This might be an oversight or the change might be in a different file not shown here.
2. pyproject.toml:3
  • Draft comment:
    No issues found related to the specified rules in this configuration file.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The pyproject.toml file does not have any issues related to the rules provided. It is a configuration file and does not contain any code logic or comments that need to be reviewed for the specified rules.

Workflow ID: wflow_ZR9Rd6JQSuvOcvAn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 1290d0f into main Oct 22, 2024
7 checks passed
@paul-paliychuk paul-paliychuk deleted the os-env-fix branch October 22, 2024 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants