Update edge search

[prasmussen15]

Important

Remove unused parameters from edge_fulltext_search and update version to 0.4.1.

• Functionality:
  • Remove source_node_uuid and target_node_uuid parameters from edge_fulltext_search() in search.py and search_utils.py.
  • Simplify Cypher query in edge_fulltext_search() by removing conditions related to source_node_uuid and target_node_uuid.
• Versioning:
  • Update version in pyproject.toml from 0.4.0 to 0.4.1.

^{This description was created by for a1ed5b8. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to a1ed5b8 in 49 seconds

More details

• Looked at 77 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. graphiti_core/search/search.py:148

• Draft comment:
  Consider removing None, None parameters from edge_similarity_search if they are not used in the function definition.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The removal of source_node_uuid and target_node_uuid from edge_fulltext_search is consistent across the codebase. However, the edge_similarity_search function still uses these parameters, which might be unnecessary if the logic is similar. This should be checked for consistency.

2. graphiti_core/search/search_utils.py:135

• Draft comment:
  Removed unused parameters source_node_uuid and target_node_uuid from edge_fulltext_search. This improves clarity and maintainability.
• Reason this comment was not posted:
  Confidence changes required: 20%
  The edge_fulltext_search function has been updated to remove unused parameters. This change is consistent with the rest of the codebase and improves clarity.

3. graphiti_core/search/search.py:148

• Draft comment:
  The parameters source_node_uuid and target_node_uuid in edge_similarity_search are not used in the function body. Consider removing them to adhere to the Single Responsibility Principle. This is also applicable in the edge_similarity_search function in search_utils.py.
• Reason this comment was not posted:
  Confidence changes required: 80%
  The function edge_similarity_search in search.py has parameters source_node_uuid and target_node_uuid that are not used in the function body. This violates the Single Responsibility Principle and makes the code less clean.

Workflow ID: wflow_ISoeCDF83512BA2d

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.