Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NEO4J_URI and port mapping in docker-compose file #366

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ArnoChenFx
Copy link
Contributor

@ArnoChenFx ArnoChenFx commented Sep 26, 2024

Important

Fix Neo4j URI and port mapping in docker-compose.ce.yaml to use hardcoded port 7687.

  • Environment Variables:
    • Fix NEO4J_URI in docker-compose.ce.yaml to use hardcoded port 7687 instead of ${NEO4J_PORT}.
  • Port Mapping:
    • Update Neo4j Bolt port mapping in docker-compose.ce.yaml from ${NEO4J_PORT}:${NEO4J_PORT} to ${NEO4J_PORT}:7687.

This description was created by Ellipsis for 86cccb4. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 86cccb4 in 6 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docker-compose.ce.yaml:58
  • Draft comment:
    Hardcoding the Neo4j port to 7687 removes flexibility. Consider using a variable for the port to allow customization.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR hardcodes the Neo4j port to 7687, which is the default port for Neo4j's Bolt protocol. This is a reasonable change if the intention is to always use the default port, but it removes flexibility if a different port is needed. The same applies to the port mapping in the docker-compose file.

Workflow ID: wflow_CDM2HOwC01ZYEWdn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@danielchalef
Copy link
Member

Our bad. Thanks for reporting, @ArnoChenFx . We've made some additional changes and will merge.

@danielchalef danielchalef merged commit 7bb1576 into getzep:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants