-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add theme's robots.txt to tera with name "robots.txt" #1722
Conversation
cee2067
to
6b3df91
Compare
Thanks!
Probably an integration test: add a robots.txt file in |
I tried this out but even if I add a
Do either of these sound good, or is there some other cleaner approach I'm missing? |
Hmm, easier test setup is definitely something that needs work. Can you just add a TODO above the code saying it needs a test and a link to that PR? We'll add a test after some refactoring |
TODO added. |
Just to confirm before merging, you did test manually that it worked correct? |
Thanks! |
* add theme's robots.txt to tera with correct name * add TODO reminder to add tests
* add theme's robots.txt to tera with correct name * add TODO reminder to add tests
* add theme's robots.txt to tera with correct name * add TODO reminder to add tests
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
This fixes #1721 by registering the theme's robots.txt template under the name "robots.txt" whereas it was previously being registered with the filepath, and later ignored during rendering.
Note: there are no tests for this PR at the moment. I'm looking into how and where to add some, but it might take me a bit.
Sanity check:
Code changes
next
branch?If the change is a new feature or adding to/changing an existing one: