Fix taxonomy current path #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemyak
force-pushed
the
fix-taxonomy-current-path
branch
from
0e0fb9b to
912041b
Compare
Keats
requested changes
Jun 3, 2022
| @@ -399,6 +399,29 @@ title = "A title" | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn does_not_duplicate_lang() { | |||
There was a problem hiding this comment.
what does it mean to duplicate lang?
There was a problem hiding this comment.
It's described in #1878.
TL;DR: currenly get_url(path='/lang/something', lang='lang') will return a URL with duplicated lang part: /lang//lang/something
| context.insert("current_url", &config.make_permalink(&self.kind.name)); | ||
| context.insert("current_path", &format!("/{}/", self.kind.name)); | ||
| context.insert("current_url", &self.permalink); | ||
| context.insert("current_path", &self.path); |
There was a problem hiding this comment.
Yes, we indeed had both permalink and path already computed in the new function, but path was discarded and permalink wasn't used. I've made it to match other similar structs e.g., Path
bemyak
force-pushed
the
fix-taxonomy-current-path
branch
from
912041b to
9208a06
Compare
Keats
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1878
Sanity check:
nextbranch?