Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always follow symlinks #1883

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Always follow symlinks #1883

merged 1 commit into from
Jun 9, 2022

Conversation

bemyak
Copy link
Contributor

@bemyak bemyak commented May 29, 2022

Despite what I've said here, symlinks don't work ATM, only an empty dir is created without contents.


Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you doing the PR on the next branch?

@Keats
Copy link
Collaborator

Keats commented Jun 3, 2022

Do we have no tests for that?

@bemyak
Copy link
Contributor Author

bemyak commented Jun 4, 2022

We don't. I'm not sure if we should though, symlinking is a file-system dependent feature, I don't know what FS CI is using

@Keats Keats merged commit 49b3107 into getzola:next Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants