Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppData #1900

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Add AppData #1900

merged 1 commit into from
Jun 26, 2022

Conversation

Ayush1325
Copy link
Contributor

Required for publishing to Flathub

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Related to #1572

@Ayush1325 Ayush1325 mentioned this pull request Jun 15, 2022
7 tasks
zola.appdata.xml Outdated
<release version="0.15.3" date="2022-01-22">
<url>https://github.com/getzola/zola/releases/tag/v0.15.3</url>
<description>
Zola Static Site Generator v0.15.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to fill that automatically on each version? I'm already forgetting to update the snapcraft file half of the time.
Does this need to be in this repo or could someone maintain it in their own repo?

Copy link
Contributor Author

@Ayush1325 Ayush1325 Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to keep it in the flathub repo but it is encouraging to put it upstream (https://github.com/flathub/flathub/wiki/App-Maintenance#acceptable-but-should-be-submitted-upstream).

Currently, it is present in the flathub pull request as well (flathub/flathub#3273). I will remove it from there if this gets merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some people invent scripts for doing it automatically, but other than that, no.

@Newbytee
Copy link
Contributor

Please rename the file to zola.metainfo.xml. appdata.xml is an old name. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html

@Ayush1325
Copy link
Contributor Author

zola.metainfo.xml

Done

zola.metainfo.xml Outdated Show resolved Hide resolved
zola.metainfo.xml Outdated Show resolved Hide resolved
zola.metainfo.xml Outdated Show resolved Hide resolved
Required for publishing to Flathub
@Keats
Copy link
Collaborator

Keats commented Jun 22, 2022

Just to double-check: this can be closed?

@Ayush1325
Copy link
Contributor Author

Just to double-check: this can be closed?

If the metadata file cannot be used by any other zola packages, then I guess it doesn't need to be merged.

@Newbytee
Copy link
Contributor

Just to double-check: this can be closed?

We currently have the metainfo downstream in the Flathub Flatpak manifest, but it would be preferable (albeit not strictly necessary) to have it here.

@Keats
Copy link
Collaborator

Keats commented Jun 24, 2022

I don't mind having it here as long as someone does a PR on new releases to update it if I forget.

@Newbytee
Copy link
Contributor

I don't mind having it here as long as someone does a PR on new releases to update it if I forget.

I can make sure that happens.

@Keats Keats merged commit fcd5331 into getzola:master Jun 26, 2022
@Ayush1325 Ayush1325 deleted the appdata branch July 11, 2022 08:46
theowenyoung added a commit to theowenyoung/zola that referenced this pull request Jul 17, 2022
* 'master' of github.com:getzola/zola:
  Set changelog date
  Update deps
  Ensure homepages get their translations filled
  Update changelog
  Fix some bugs + cargo fmt
  Update pinned rustc version
  Update deps
  Insert anchor as full heading (getzola#1916)
  Fix misspelling in documentation (getzola#1914)
  Add AppData (getzola#1900)
  Add flatpak installation to docs (getzola#1906)
  Update themes gallery (getzola#1899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants