Fix incorrect documentation for syntax directory #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Configuration docs says to load syntax files into config.toml [markdown] extra_syntaxes. However, ever since commit 23064f5 (released in Zola v0.15.0), the extra_syntaxes property was replaced by extra_syntaxes_and_themes, and used as both syntax and color theme search paths. Following the docs and trying to set the extra_syntaxes property does nothing, and getzola#1723 ran into this issue. Change the docs to consistently reference extra_syntaxes_and_themes.
Keats
approved these changes
Jun 16, 2022
|
It's ok on next, the next release is not that far away. |
theowenyoung
added a commit
to theowenyoung/zola
that referenced
this pull request
Jul 8, 2022
* 'next' of github.com:getzola/zola: Apply orientation transformation based on EXIF data (getzola#1912) Stop printing invalid files in dirs fix windows EOL in markdown files (getzola#1911) Properly escape anchor names (getzola#1908) Allow new lines before anchor (getzola#1905) Fix incorrect documentation for syntax directory (getzola#1901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Configuration docs says to load syntax files into config.toml
[markdown] extra_syntaxes. However, ever since 23064f5 (released in Zola v0.15.0), theextra_syntaxesproperty was replaced byextra_syntaxes_and_themes, and used as both syntax and color theme search paths. Following the docs and trying to set theextra_syntaxesproperty does nothing, and #1723 ran into this issue.Change the docs to consistently reference
extra_syntaxes_and_themes.Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
Should this be merged into next or master? If merged directly into master (to edit live docs), you need to cherry-pick #1606 as well, since that PR partly fixed the docs and this fixes the remaining errors.