Filter more than 1 footnote in summary #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the summary contains more than 1 footnote, only the 1st is removed, and so dangling links exists for all the others.
BartG95
reviewed
Nov 11, 2022
|
|
||
| [^1]: This is the first footnote. | ||
|
|
||
| [^2]: This is the second footnote."# | ||
| [^2]: This is the secund footnote. |
There was a problem hiding this comment.
Is the spelling error in "second" intentional?
There was a problem hiding this comment.
secund is a word... but it doesn't fit in that sentence. Maybe auto correct?
There was a problem hiding this comment.
Nah, likely just a typo in my patch, sorry. i was more focused on the Rust code than the text.
Keats
pushed a commit
that referenced
this pull request
Feb 16, 2023
If the summary contains more than 1 footnote, only the 1st is removed, and so dangling links exists for all the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the summary contains more than 1 footnote, only the 1st is removed, and so dangling links exists for all the others.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?