Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deploy-gh-pages): add workflow permissions #2249

Merged
merged 1 commit into from
Jul 18, 2023
Merged

docs(deploy-gh-pages): add workflow permissions #2249

merged 1 commit into from
Jul 18, 2023

Conversation

FineFindus
Copy link
Contributor

Adds a reminder to change the workflow permissions to read and write for deployment to GitHub pages. This should fix bugs like shalzz/zola-deploy-action#77.
While this is already documented in shalzz/zola-deploy-action#59, I think it is worth adding as it can easily be overlooked or the user may not have visited the deploy action repo when following the documentation.

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@Keats Keats merged commit f93bd90 into getzola:master Jul 18, 2023
@FineFindus FineFindus deleted the patch-1 branch July 18, 2023 13:23
biodranik pushed a commit to biodranik/zola that referenced this pull request Sep 12, 2023
technimad pushed a commit to technimad/zola that referenced this pull request Sep 30, 2023
Drodt pushed a commit to DerDrodt/zola that referenced this pull request Oct 10, 2023
fredr pushed a commit to fredr/zola that referenced this pull request Oct 21, 2023
selfisekai pushed a commit to selfisekai/zola that referenced this pull request Nov 3, 2023
Newbytee pushed a commit to Newbytee/zola that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants