Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document author #2347

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Document author #2347

merged 2 commits into from
Oct 30, 2023

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Oct 30, 2023

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This adds author to the page that shows what fields are available in the configuration.

It also explains how the author from the configuration and authors from the front matter are used for feeds.

I'm on the fence about how to add author to the configuration as it is blank and not set to "Unknown" that happens in the feed template. However, the way I've done it causes the config not to work if you just copy and paste it, without editing it. I think that's probably bad but I patterned on the front matter documentation where the date and update are done the same way. I considered commenting out the line but then it's easier to miss. Not sure what is the best way to treat this.

@c-git
Copy link
Contributor Author

c-git commented Oct 30, 2023

I'm unable to link this PR to the related issue.

@Keats Keats merged commit 7d5ce5c into getzola:master Oct 30, 2023
5 checks passed
@Keats
Copy link
Collaborator

Keats commented Oct 30, 2023

Thanks!

@c-git c-git deleted the document_author branch October 31, 2023 00:20
selfisekai pushed a commit to selfisekai/zola that referenced this pull request Nov 3, 2023
* Add author to documentation for config.toml

* Add explanation of how author is used for feeds
Newbytee pushed a commit to Newbytee/zola that referenced this pull request Dec 19, 2023
* Add author to documentation for config.toml

* Add explanation of how author is used for feeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants