Handle file events emitted by Nova on macOS #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the bug report #2663, I've added a branch to the match expression to catch EventKind::Modify(ModifyKind::Name(RenameMode::Any)) events made by Nova on macOS when editing files.
It appears that this is the only event that makes it to meaningful_events: HashMap<PathBuf, (PathBuf, SimpleFileSystemEventKind, ChangeKind)> when using Nova.
In testing this change, I discovered that other editors including Helix 24.7 and Vim 9.0.2142 also emit this event, but go on to emit others.
This change didn't introduce problems when editing with:
Helix 24.7
Vim 9.0.2142
Sublime Text Build 4180
on macOS 14.6.1.
Let me know if you want further testing (or tests) added.
NOTE: This supersedes PR #2672 where I had based my change on
masternotnext, and therefore including other changes. Apologies.Cheers, Jamie.