Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan gh-release <semver> doesn't work with GITHUB_TOKEN defined #67

Closed
bianchidotdev opened this issue Sep 23, 2021 · 2 comments
Closed

Comments

@bianchidotdev
Copy link
Contributor

Sorry for the noise 😢 , I'm just trying to get chan set up in GitHub Actions with a project I'm managing and I'm running into small issues.

Current behavior

 λ unset GITHUB_TOKEN
 λ chan gh-release 0.1.3
[chan] [gh-release] › ℹ  info      Uploading GitHub release...

 λ export GITHUB_TOKEN=<REDACTED>
 λ chan gh-release 0.1.3
[chan] [gh-release] › ℹ  info      Uploading GitHub release...
[chan] [gh-release] › ✖  error     TypeError: Cannot read property 'createRelease' of undefined
    at createGithubRelease (file:///Users/mbianchi/workspace/dev/dotfiles/config/yarn/global/node_modules/@geut/chan/src/commands/gh-release.js:84:26)
    at Object.handler (file:///Users/mbianchi/workspace/dev/dotfiles/config/yarn/global/node_modules/@geut/chan/src/commands/gh-release.js:55:9)

The usage of GITHUB_TOKEN is causing an error of the createRelease command, though I can't figure out why. The usage in gh-release looks correct, but maybe something isn't set properly in the data object.

@bianchidotdev
Copy link
Contributor Author

On second look at this, it looks like the call needs to be github.rest.repos.createRelease. I'm not sure if something has changed since this was originally written

@dpaez
Copy link
Contributor

dpaez commented Sep 24, 2021

Closed with #68

New release out: v3.2.2

@dpaez dpaez closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants