Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference correct octokit action for creating release #68

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

bianchidotdev
Copy link
Contributor

@bianchidotdev bianchidotdev commented Sep 23, 2021

Hello! This is for a fix for creating GitHub releases (#67 )

What I've done:

  1. Updated octokit command for createRelease
  2. Verified no existing tests have regressed
lerna success run Ran npm script 'lint' in 6 packages in 6.8s:
lerna success - @geut/chan-core
lerna success - @geut/chan-stringify
lerna success - @geut/chan
lerna success - @geut/chast
lerna success - @geut/git-url-parse
lerna success - @geut/remark-chan
  1. Verified new code creates release successfully
 λ npm link
 λ chan added "New chan release"
[chan] [added] › ✔  success   Added new changes on your changelog.
 λ chan release 0.1.4
[chan] [release] › ✔  success   New release created. 0.1.4
 λ export GITHUB_TOKEN=<REDACTED>
 λ chan gh-release 0.1.4
[chan] [gh-release] › ℹ  info      Uploading GitHub release...
[chan] [gh-release] › ✔  success   GitHub release created.

What I did not do:

  1. Write new tests to validate this behavior 😞 - I really have no idea how I would do that here in js

@dpaez
Copy link
Contributor

dpaez commented Sep 24, 2021

Hi @michaeldbianchi this looks great. Thanks for the PR!

Would you mind adding a new changelog entry? Can be something like this:

chan fixed 'reference correct octokit action for creating release #67'

Thanks!

@bianchidotdev
Copy link
Contributor Author

Updated the changelog. Thanks for taking the time to review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants