Merge pull request #125 from asfaltboy/ps/import-a005-module-dir

feat(A005): support detecting a shadowing folder
gforcada · Apr 9, 2024 · 3890afb · 3890afb
2 parents 5b6dbff + b46b4d7
commit 3890afb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -6,7 +6,8 @@ Changelog
 2.4.1 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Support detecting a shadowing folder as module name (as part of `A005`).
+  [asfaltboy]
 
 
 2.4.0 (2024-04-01)

diff --git a/flake8_builtins.py b/flake8_builtins.py
@@ -293,7 +293,10 @@ def check_module_name(self, filename: str):
         if not self.module_names:
             return
         path = Path(filename)
-        module_name = path.name.removesuffix('.py')
+        if path.name == '__init__.py':
+            module_name = path.parent.name
+        else:
+            module_name = path.name.removesuffix('.py')
         if module_name in self.module_names:
             yield self.error(
                 None,

diff --git a/run_tests.py b/run_tests.py
@@ -510,6 +510,7 @@ def test_tuple_unpacking():
 def test_module_name():
     source = ''
     check_code(source, expected_codes='A005', filename='./temp/logging.py')
+    check_code(source, expected_codes='A005', filename='./temp/typing/__init__.py')
 
 
 @pytest.mark.skipif(