Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugbear and builtins both using B001 #7

Closed
cas-- opened this issue Aug 9, 2017 · 3 comments
Closed

Bugbear and builtins both using B001 #7

cas-- opened this issue Aug 9, 2017 · 3 comments

Comments

@cas--
Copy link

cas-- commented Aug 9, 2017

I have not tested the consequences of this but I found googling for B001 that you both picked the same B prefix code in March 2016!

https://github.com/PyCQA/flake8-bugbear#list-of-warnings

@ambv
Copy link

ambv commented Aug 10, 2017

As bugbear is an official PyCQA plugin, it would be probably best for the author to change the code used by flake8-builtins.

@gforcada
Copy link
Owner

@ambv I, as the author, wouldn't mind changing it to X, Y, Z or whatever word, problem is as soon as you get more than 26 plugins... what should we do? https://pypi.org/search/?q=flake8 already reports 423 projects... Is that something that flake8 has already thought about?

I've seen that a plugin can claim not only a word but part of a letter as well, i.e. B0 (giving you B001 to B099orB00`` which gives only B001 to B009), so maybe bugbear could restrict itself a little bit as well...

Anyway, I will make a major breaking release of builtins plugin and I will pick up... A for example.

gforcada added a commit that referenced this issue Aug 18, 2017
gforcada added a commit that referenced this issue Aug 19, 2017
@gforcada
Copy link
Owner

@cas-- @ambv flake8-builtins 1.0 is released with the error codes changed to A00X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants