Added check for edge case where byte string is empty. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this relate to #8? |
|
I didn't see that issue before, but it is related - the body definition that causes this bug is |
gfredericks
added a commit
that referenced
this pull request
Dec 14, 2015
Added check for edge case where byte string is empty.
|
Gotcha -- I had forgotten we handled both byte arrays and input streams. Thanks! I just released this as |
|
Cool, thanks for the quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an edge case I came across while testing DELETE calls - if the recorded response body is empty, an exception is thrown because it's decoding an invalid base64 string.
There are a couple of different ways to fix this, but I went for the simplest: an empty check in str->bytes.