[LL] Make DX12 ~~great~~ compile again! #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiglreith
suggested changes
Jun 8, 2017
src/backend/dx12ll/src/data.rs
Outdated
| state = state | D3D12_RESOURCE_STATE_PRESENT; | ||
| match layout { | ||
| ImageLayout::Present => { | ||
| state = state | D3D12_RESOURCE_STATE_PRESENT; |
There was a problem hiding this comment.
D3D12_RESOURCE_STATE_PRESENT is not a flag, it is actually 0!
https://msdn.microsoft.com/de-de/library/windows/desktop/dn986744(v=vs.85).aspx
edit: I just noticed that I did it wrong myself.. eh ResourceStates are one of the open problems left and for the moment we could just define them both (vulkan access and d3d12 states) for pipeline barriers.
|
Fixed now |
msiglreith
approved these changes
Jun 8, 2017
|
@homu r=msiglreith |
|
📌 Commit 7d9f997 has been approved by |
homu
added a commit
that referenced
this pull request
Jun 8, 2017
[LL] Make DX12 ~~great~~ compile again! This is a big WIP work, but I think we can merge this at any point in order to minimize friction with other changes.
|
Oh snap, dxguid fails to compile on AppVeyor due to OOM. Might be related to the compiler bug folks have been discussing on IRC (cc @torkleyy). |
|
It is, it's a regression on nightly / beta. It's talked through as we speak AFAIK. |
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big WIP work, but I think we can merge this at any point in order to minimize friction with other changes.