Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recovery of failed enumeration of physical devices #2902

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

dpmkl
Copy link
Contributor

@dpmkl dpmkl commented Jul 12, 2019

Fixes #2783
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends: vulkan
  • rustfmt run on changed code
    I looked through all other backends and could not find any other obvious unrecoverable aborts.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 12, 2019
2902: Fix recovery of failed enumeration of physical devices r=kvark a=dpmkl

Fixes #2783
PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: vulkan
- [ ] `rustfmt` run on changed code
I looked through all other backends and could not find any other obvious unrecoverable aborts. 

Co-authored-by: Michael Craggs <m.e.craggs@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 12, 2019

Build succeeded

@bors bors bot merged commit ca35839 into gfx-rs:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should have a way of telling whether backend is supported
2 participants