[mtl] Properly set store operation for depth attachment #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Dec 30, 2019
3115: [mtl] Properly set store operation for depth attachment r=kvark a=cbrewster Found this while looking into gfx-rs/wgpu#103. Looks like this was a copy-paste mistake, this partially fixes the wgpu shadow example on mac. PR checklist: - [x] `make` succeeds (on macOS) - [x] `make reftests` succeeds - [ ] tested examples with the following backends: - [x] `rustfmt` run on changed code Co-authored-by: Connor Brewster <connor.brewster@eagles.oc.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while looking into gfx-rs/wgpu#103. Looks like this was a copy-paste mistake, this partially fixes the wgpu shadow example on mac.
PR checklist:
makesucceeds (on macOS)make reftestssucceedsrustfmtrun on changed code