Move OpenGL device implementation into separate directory #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be converted into a crate once associated items are added and used in the `Device` trait. See rust-lang/rfcs#195
Contributor
Author
|
Just a sec - need to fix a warning. |
Member
|
Sweet! |
kvark
added a commit
that referenced
this pull request
Sep 1, 2014
Move OpenGL device implementation into separate directory
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
341: Track and destroy samplers r=kvark a=yanchith This PR adds `ResourceId::Sampler`, `NativeResource::Sampler` and `TrackerSet::samplers`. Samplers are (similarly to bind groups) created with their own life guard and a device id to keep the device ref count alive. Also added are `extern wgpu_sampler_destroy` and `sampler_destroy`. The rest of the implementation was guided by compiler errors, so there is a good chance I didn't find something crucial that also needed doing. Please check :) I also imagine we might want to add the `Drop` impl for sampler in wgpu-rs. Fixes: gfx-rs#231 Co-authored-by: yanchith <yanchi.toth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be converted into a crate once associated items are added and used in the
Devicetrait. See rust-lang/rfcs#195.The generated gl bindings have been moved to a separate crate. This fixes the private export warning, speeds up incremental build time, and allows folks to use
GlDevice::with_glbetter.I also marked
GlDevice::with_glas unsafe because it can potentially mess with the state of the OpenGL context.