-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GL] Testing with the Android Emulator on CI #3604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff!
examples/quad_android/src/lib.rs
Outdated
@@ -0,0 +1,935 @@ | |||
#[cfg(not(any( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this have to be a separate example? could we make it a part of the existing quad
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a separate example because we need to compile crate-type = ["cdylib"]
for Android. This should be partially fixed, because I removed most of code duplication.
aff3acb
to
b85e539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is starting to look great!
@@ -0,0 +1,37 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another option, not necessarily a better one, is to have examples/src/lib.rs
, so that the project is a cdylib
library with binaries. The library would only be doing stuff on Android at this moment, but maybe we can find more use for this later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo apk
allows run apk file only from cargo workspace root. But cargo doesn't allow pass features in cargo workspace root.
error: --features is not allowed in the root of a virtual workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is error already fixed in cargo-apk
. I will try to remove more code duplication with examples/src/lib.rs
.
I'm going to close this PR, since |
Just a proof-of-concept of how we can run a
quad example
on CI with the Android Emulator.All other jobs temporary removed (for speed up).
TODO:
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ndk-glue-0.2.1/src/lib.rs:255:34
Sometimes running apps panicked on the Android Emulator rust-mobile/ndk#116