Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rspirv crate #1187

Closed
Jasper-Bekkers opened this issue Aug 11, 2021 · 11 comments
Closed

Updating rspirv crate #1187

Jasper-Bekkers opened this issue Aug 11, 2021 · 11 comments
Labels
lang: SPIR-V Binary SPIR-V input and output

Comments

@Jasper-Bekkers
Copy link

Creating this ticket since we had some breakage in this project the last time we tried to update rspirv. This was tracked in gfx-rs/rspirv#196 but we'd like to announce it here as well since we're planning on pushing a new update to rspirv soon (with a seperate spirv crate instead of spirv_headers).

Historically the semver handing of rspirv hasn't been ... great, which is something we're working on fixing but I thought I'd give a small heads up at least.

@kvark kvark added the lang: SPIR-V Binary SPIR-V input and output label Aug 11, 2021
@Jasper-Bekkers
Copy link
Author

Jasper-Bekkers commented Aug 16, 2021

@kvark we have just pushed rspirv 0.9.0 and spirv 0.1.0, henceforth spirv_headers will be deprecated.

@Jasper-Bekkers Jasper-Bekkers changed the title Updating rspirvcrate Updating rspirv crate Aug 16, 2021
@kvark
Copy link
Member

kvark commented Aug 16, 2021

I'm having a bit of an issue updating

warning: /Users/dmalyshau/Code/naga/Cargo.toml: version requirement 0.1.0+1.5.4 for dependency spirv includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion
warning: /Users/dmalyshau/Code/naga/Cargo.toml: version requirement 0.1.0+1.5.4 for dependency spirv includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion
Updating crates.io index
Downloaded spirv v0.1.0
error: failed to verify the checksum of spirv v0.1.0

@kvark
Copy link
Member

kvark commented Aug 16, 2021

Stripping the "+1.5.4" removes the warnings but I'm left with

failed to verify the checksum of spirv v0.1.0

@Jasper-Bekkers
Copy link
Author

Yeah, you're not supposed to specify the metadata with the version.

The checksum issue is a bit odd - we didn't get that issue when publishing a new rspirv update.

@kvark
Copy link
Member

kvark commented Aug 16, 2021

Removing everything with cargo-cache -r all doesn't help either. And I'm seeing this on an empty project (just adding spirv = "0.1" dependency). Something is fishy here.

@Jasper-Bekkers
Copy link
Author

@kvark I seem to be getting the same issue locally - I'll investigate.

@Jasper-Bekkers
Copy link
Author

Seems related to rust-lang/cargo#7180

@Jasper-Bekkers
Copy link
Author

Jasper-Bekkers commented Aug 16, 2021

Seems like there used to be an old version of spirv at 0.1.0 (that was yanked before) that cargo fetch compares against incorrectly. I'll just release a 0.2.0 and that should work 🤞

Edit: Seems to work for me locally now with 0.2.0.

@kvark
Copy link
Member

kvark commented Aug 16, 2021

Thanks! Unfortunately, now rspirv also needs to be updated, since it still tries to drag in the old spirv-0.1.0

@Jasper-Bekkers
Copy link
Author

Pushed a new version of rspirv now as well. I'll close this as it looks like there wasn't any major fallout from this release. Further issues can be discussed on the rspirv repo directly.

@kvark
Copy link
Member

kvark commented Aug 18, 2021

Thanks! Just as I needed this. Naga-0.6 is also released now, using the new spirv crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: SPIR-V Binary SPIR-V input and output
Projects
None yet
Development

No branches or pull requests

2 participants