Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published 1.5.1 broke public API #196

Closed
kvark opened this issue May 5, 2021 · 8 comments
Closed

Published 1.5.1 broke public API #196

kvark opened this issue May 5, 2021 · 8 comments
Labels

Comments

@kvark
Copy link
Member

kvark commented May 5, 2021

https://docs.rs/spirv_headers/1.5.0/spirv_headers/enum.ExecutionMode.html#method.required_capabilities is gone.
See also - gfx-rs/naga#836
cc @Jasper-Bekkers

@kvark kvark added the bug label May 5, 2021
@Jasper-Bekkers
Copy link
Collaborator

spirv_headers don't follow semantic versioning so breakage like this is sort-of unavoidable without some changes to the policy of this project :-(

We've run into this before with #117

@Jasper-Bekkers
Copy link
Collaborator

For reference - required_capabilities and required_extensions got moved into Operand instead because there can be multiple capabilties or extensions required.

@kvark
Copy link
Member Author

kvark commented May 5, 2021

Wait, #117 was actually fixed, and sanity was restored. Are you saying that the current breakage is intended?

@Jasper-Bekkers
Copy link
Collaborator

In #117 a workaround got introduced to not break semver, however in this case I'm not sure we can (see previous comment).

@Jasper-Bekkers
Copy link
Collaborator

It's specifically this comment that explains why we're in this spot though I'm not a big fan (for obvious reasons).

@antiagainst
Copy link
Collaborator

antiagainst commented May 5, 2021

That comment was made quite some time ago when we saw the first breakage. Things do change and I'm certainly not trying to hold back improvements. :) We had similar discussions in another thread later (see here) where I suggested to retire the spirv_headers create and use the spirv crate instead to have a clean slate for using semver. This might be the time to really push towards that.

@Jasper-Bekkers
Copy link
Collaborator

@antiagainst Agreed, filed #197 for further discussion around how to proceed :-)

@ErichDonGubler
Copy link
Member

Given that #197 is closed now, does that this mean issue is resolved?

@kvark kvark closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants