-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published 1.5.1 broke public API #196
Comments
spirv_headers don't follow semantic versioning so breakage like this is sort-of unavoidable without some changes to the policy of this project :-( We've run into this before with #117 |
For reference - required_capabilities and required_extensions got moved into |
Wait, #117 was actually fixed, and sanity was restored. Are you saying that the current breakage is intended? |
In #117 a workaround got introduced to not break semver, however in this case I'm not sure we can (see previous comment). |
It's specifically this comment that explains why we're in this spot though I'm not a big fan (for obvious reasons). |
That comment was made quite some time ago when we saw the first breakage. Things do change and I'm certainly not trying to hold back improvements. :) We had similar discussions in another thread later (see here) where I suggested to retire the |
@antiagainst Agreed, filed #197 for further discussion around how to proceed :-) |
Given that #197 is closed now, does that this mean issue is resolved? |
https://docs.rs/spirv_headers/1.5.0/spirv_headers/enum.ExecutionMode.html#method.required_capabilities is gone.
See also - gfx-rs/naga#836
cc @Jasper-Bekkers
The text was updated successfully, but these errors were encountered: