[wgsl-in]: Correctly compare pointer types. #1381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a welcome improvement! Let's chat about #1385 briefly before we proceed. |
Treat `TypeInner::ValuePointer` and `TypeInner::Pointer` as equivalent by converting them to a canonical form before comparison. Support `ValuePointer` in WGSL type output. Fixes gfx-rs#1318.
jimblandy
force-pushed
the
value-pointer-equivalent
branch
from
daf8489 to
7fab22a
Compare
|
Hasn't this been included in on of the landed PRs? |
|
This has been merged into master now. Not sure why GitHub doesn't think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat
TypeInner::ValuePointerandTypeInner::Pointeras equivalent byconverting them to a canonical form before comparison.
Support
ValuePointerin WGSL type output.Fixes #1318.