Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement integral-bool casts in SPV, MSL, and HLSL backends #1459

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Oct 12, 2021

Fixes #1458
Comes with a test!

@kvark kvark changed the title Fix float-bool casts in MSL and HLSL backends Implement integral-bool casts in SPV, MSL, and HLSL backends Oct 12, 2021
@kvark kvark merged commit ee450c1 into gfx-rs:master Oct 12, 2021
@kvark kvark deleted the bool-cast branch October 12, 2021 15:42
@kvark kvark added the can backport PR that can be back-ported to a release branch label Oct 12, 2021
@kvark kvark removed the can backport PR that can be back-ported to a release branch label Dec 2, 2021
@kvark kvark mentioned this pull request Dec 2, 2021
@kvark
Copy link
Member Author

kvark commented Dec 2, 2021

Published in 0.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[msl-out] Metal backend giving module is not valid for validated wgsl input
1 participant