Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glsl-out] Fix initializers not being written #1644

Merged
merged 4 commits into from
Jan 4, 2022

Conversation

JCapucho
Copy link
Collaborator

@JCapucho JCapucho commented Jan 3, 2022

The zero initializing was inhibiting the output of initializers for structs and arrays, this PR reenables the output of initializers for them and for completeness also implements implements zero initialization for them.

Fixes #1638

@JCapucho JCapucho requested a review from kvark January 3, 2022 22:44
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

tests/out/glsl/operators.main.Compute.glsl Outdated Show resolved Hide resolved
@kvark
Copy link
Member

kvark commented Jan 3, 2022

Please merge when feel ready.

@JCapucho JCapucho merged commit 743d058 into gfx-rs:master Jan 4, 2022
@JCapucho JCapucho deleted the glsl-out-const-array branch January 4, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to define constant vertices array in WGSL for usage in GLSL
2 participants