glsl-in: Type qualifiers rework #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Feb 4, 2022
The previous implementation had many issues, most importantly it didn't allow to implement (at least in a sane way) some future features like default qualifiers and format qualifiers. This implementations centralizes the qualifiers into a struct with a hashmap for layout qualifiers, error reporting is also centralized which means that `add_global_var` and `add_local_var` no longer need to duplicate effort and the ugly loop + match combo is gone. Finally some minor fixes are also done as part of this rework, like a default location being provided for input/outputs variables and layout qualifiers being allowed to be repeated (overwriting the previous one) like the spec defines.
JCapucho
force-pushed
the
glsl-qualifiers-rework
branch
from
e746b5c to
c9224b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation had many issues, most importantly it didn't
allow to implement (at least in a sane way) some future features like
default qualifiers and format qualifiers.
This implementations centralizes the qualifiers into a struct with a
hashmap for layout qualifiers, error reporting is also centralized which
means that
add_global_varandadd_local_varno longer need toduplicate effort and the ugly loop + match combo is gone.
Finally some minor fixes are also done as part of this rework, like
a default location being provided for input/outputs variables, layout
qualifiers being allowed to be repeated (overwriting the previous one)
like the spec defines, more syntax validation is added to qualifiers and
more errors are made to not stop parsing when encountered.