Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msl-out][spv-out][glsl-out] Implement ArraySize on globals. #1717

Merged
merged 2 commits into from
Feb 5, 2022
Merged

[msl-out][spv-out][glsl-out] Implement ArraySize on globals. #1717

merged 2 commits into from
Feb 5, 2022

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Feb 4, 2022 •
edited
Loading

Remaining work:

  • HLSL

kvark
kvark reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@jimblandy jimblandy force-pushed the raw-global-array-size branch 2 times, most recently from 4c1ac0f to ea8b960 Compare February 5, 2022 01:04
@jimblandy
Copy link
Member Author

(My SPIR-V was using the wrong id, too...)

@jimblandy jimblandy marked this pull request as ready for review February 5, 2022 01:05
@jimblandy
Copy link
Member Author

looking at macOS

@jimblandy
[msl-out] Always check whether _buffer_sizes arg is needed.
2f9dda0 
The _buffer_sizes argument should be inserted regardless of whether or not `
`options.fake_missing_bindings` is set, so lift the computation of
`supports_array_length` out of that conditional.
@jimblandy
[msl-out][spv-out][glsl-out][hlsl-out] Fix ArraySize on globals.
47011ba
kvark
kvark approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@kvark kvark merged commit 0ce98d6 into gfx-rs:master Feb 5, 2022
@IcanDivideBy0 IcanDivideBy0 mentioned this pull request Feb 5, 2022
Merged
@kvark kvark mentioned this pull request Feb 6, 2022
Merged
@jimblandy jimblandy deleted the raw-global-array-size branch February 21, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @kvark