Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glsl-in: Fix freestanding constructor parsing #1758

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

JCapucho
Copy link
Collaborator

@JCapucho JCapucho commented Mar 3, 2022

This required doing backtracking in order to select between a declaration statement and a expression statement.

This PR is divided into 2 parts, each with it's own commit that can be reviewed and tested individually:

  • Implementing backtracking
  • Fixing the constructor freestanding parsing

Closes #1554

@kvark kvark merged commit a2bcdda into gfx-rs:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[glsl-in] naga rejects shader that uses lone vec4 expression.
2 participants