Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not operator depending on expression type #1760

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Not operator depending on expression type #1760

merged 1 commit into from
Mar 6, 2022

Conversation

vincentisambart
Copy link
Contributor

Fixes #1252

In HLSL and MSL, when outputting a not operator, look at the expression type to choose the correct operator.

Mostly took code from the GLSL backend and adapted it for the other backends.

@vincentisambart vincentisambart mentioned this pull request Mar 4, 2022
Closed
kvark
kvark approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Note that the backend doesn't need to validate. So it could just check for float in an "if/else" fashion, assuming it's correct.

@kvark kvark merged commit fe3d945 into gfx-rs:master Mar 6, 2022
@kvark kvark added the can backport PR that can be back-ported to a release branch label Mar 6, 2022
@vincentisambart vincentisambart deleted the not-type branch March 11, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
can backport PR that can be back-ported to a release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[msl-out] Bitwise negation is broken for Metal
2 participants
@vincentisambart @kvark