glsl-in: Fix memory qualifiers being inverted #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-fix-access
branch
from
4c68d74 to
4e88c28
Compare
kvark
reviewed
Mar 19, 2022
JCapucho
force-pushed
the
glsl-fix-access
branch
from
4e88c28 to
fcd6bea
Compare
Adds some documentation to better explain how the memory qualifier works troughout the parser and some storage textures tests.
JCapucho
force-pushed
the
glsl-fix-access
branch
from
fcd6bea to
3554c19
Compare
kvark
reviewed
Mar 20, 2022
| if let Some((restricted_access, _)) = qualifiers.storage_acess.take() { | ||
| access.remove(restricted_access); | ||
| if let Some((allowed_access, _)) = qualifiers.storage_acess.take() { | ||
| *access = allowed_access; |
There was a problem hiding this comment.
shouldn't this be *access &= allowed_access; instead?
There was a problem hiding this comment.
It's the same thing since the only way to change access which defaults to all is trough memory qualifiers
kvark
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some documentation to better explain how the memory qualifier works
troughout the parser and some storage textures tests.
Closes #1770