glsl-in: Allow multiple array specifiers #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-multidim-arrays
branch
from
7676abe
to
cb88aba
Compare
kvark
reviewed
Mar 19, 2022
| meta.subsume(end_meta); | ||
| Ok(Some((ArraySize::Constant(constant), meta))) | ||
|
|
||
| Ok(true) |
There was a problem hiding this comment.
I don't understand why we are mutating ty and returning Ok(bool) if we could instead return something like Result<Option<Handle<Type>>>. Do you think this would be a feasible thing to change here?
There was a problem hiding this comment.
We definitely could but I don't what the benefit would be since we would be mutating the type anyways.
There was a problem hiding this comment.
Where would we be mutating the type? This would just return a new type.
Or do you mean that the caller would likely reassign the type anyway? That's OK, I think.
There was a problem hiding this comment.
Yes the caller always reassigns the type
There was a problem hiding this comment.
I think that would still be a better internal API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1769