Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msl-out] Fix packed vec3 stores #1816

Merged
merged 5 commits into from
Apr 12, 2022
Merged

[msl-out] Fix packed vec3 stores #1816

merged 5 commits into from
Apr 12, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 10, 2022 •
edited
Loading

closes #1633
fixes #1561

See spec for details on packed vector accesses.

@teoxoy teoxoy marked this pull request as ready for review April 10, 2022 17:26
@teoxoy teoxoy changed the title [msl-out] Packed vec3 improvements [msl-out] Fix packed vec3 stores Apr 10, 2022
@teoxoy teoxoy marked this pull request as draft April 10, 2022 21:50
@teoxoy teoxoy marked this pull request as ready for review April 11, 2022 13:39
@teoxoy
Copy link
Member Author

teoxoy commented Apr 11, 2022

Added more tests for packed vec3's and fixed issue in #1561 by casting them if they are used in expressions that MSL doesn't support on packed vec3's.

@kvark let me know if this is good to go or have any concerns with the approach.

@kvark kvark merged commit 0e77d26 into gfx-rs:master Apr 12, 2022
@teoxoy teoxoy deleted the msl-out-packed-vec3-improvements branch April 12, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packed vector support in MSL [msl-out] Generated metal uses packed_float3 in an expression
2 participants
@teoxoy @kvark