Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] Update entry point stage attributes #1833

Merged
merged 2 commits into from
Apr 15, 2022
Merged

[wgsl-in] Update entry point stage attributes #1833

merged 2 commits into from
Apr 15, 2022

Conversation

Gordon-F
Copy link
Collaborator

Fix #1830

JCapucho
JCapucho approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but you're using some rust features that are above the MSRV so this needs to fixed.

@Gordon-F
Copy link
Collaborator Author

@JCapucho Fixed. Thank you!

@JCapucho JCapucho merged commit 1720725 into gfx-rs:master Apr 15, 2022
@Gordon-F Gordon-F deleted the stage_attributes branch April 15, 2022 17:05
@Gordon-F Gordon-F mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCapucho JCapucho JCapucho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Update entry point stage attributes
2 participants
@Gordon-F @JCapucho