Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI minimal-versions checking for dependencies #1840

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 16, 2022

Depends on #1838 (will rebase once it lands)

Adds minimal-versions checking for dependencies to CI and fixes minimal versions of some of our dependencies.

Relevant links

Tested locally via
cargo msrv verify -- cargo minimal-versions test --all-features --workspace (cargo-msrv, cargo-minimal-versions)

@teoxoy teoxoy force-pushed the minimal-versions branch from e71dcf1 to cee58fc Compare April 16, 2022 15:35
@teoxoy teoxoy marked this pull request as ready for review April 16, 2022 15:37
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's finally there! I remember asking for this in cargo some eternity ago.

@teoxoy
Copy link
Member Author

teoxoy commented Apr 17, 2022

Not sure why the CI is expecting "Test MSRV" to report its status since it has been renamed.

@kvark
Copy link
Member

kvark commented Apr 18, 2022

@teoxoy the name of the job is listed in the branch protection settings. So unfortunately we have to manually update them.

@kvark kvark merged commit bddfc34 into gfx-rs:master Apr 18, 2022
@teoxoy teoxoy deleted the minimal-versions branch April 18, 2022 08:05
@teoxoy teoxoy mentioned this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants