Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Make use of new language features #1841

Merged
merged 6 commits into from
Apr 17, 2022

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Apr 16, 2022

Depends on #1838 (will rebase once it lands)

@teoxoy teoxoy force-pushed the make-use-of-new-lang-features branch from 45b92c6 to 0d3be5e Compare April 16, 2022 15:36
@teoxoy teoxoy marked this pull request as ready for review April 16, 2022 15:37
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
Although, the proliferation of const makes me worry a bit if this is a step in the direction of public static void main() verbosity level of Java :)

@kvark
Copy link
Member

kvark commented Apr 17, 2022

@cwfitzgerald should decide if this lands now or after #1845

@cwfitzgerald
Copy link
Member

Let's land this first, I should touch up that one function anyway and I won't do that until tomorrow night.

@cwfitzgerald cwfitzgerald merged commit 7ce98dc into gfx-rs:master Apr 17, 2022
@teoxoy teoxoy deleted the make-use-of-new-lang-features branch April 17, 2022 08:07
@teoxoy teoxoy mentioned this pull request Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants