glsl-in: Fix the ternary operator to behave like an if #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GLSL specification defines that only one of the branches should be evaluated making the ternary operator syntatic sugar for an `if`.
Adds a new method `emit_restart` to perform the common operation of flushing the `emitter` to the body and starting it again. Adds documentation to all context emitter related methods
jimblandy
approved these changes
May 1, 2022
jimblandy
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1854
As pointed out in the issue, the glsl spec defines that only one of the expressions should be evaluated making the ternary operator syntactic sugar to an
if.There are two commits that can be reviewed and tested separately, the first contains the actual fix and is the majority of the work. The seconds introduces a new method to the
Contextcalledemit_restartthat performs a very common operation on the frontend of flushing the emitter and restarting it.