Add HLSL validation via FXC to CI #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gordon-F
reviewed
May 14, 2022
| name=`echo $${vertex[i]} | cut -d \: -f 1`; \ | ||
| profile=`echo $${vertex[i]} | cut -d \: -f 2`; \ | ||
| sm=`echo $${profile} | cut -d \_ -f 2`; \ | ||
| if (( sm < 6 )); then \ |
There was a problem hiding this comment.
Is it necessary to add shader model version check?
There was a problem hiding this comment.
FXC doesn't support any SM >= 6. When we add f16 support which requires SM6.2 the validation would fail but shouldn't.
Gordon-F
approved these changes
May 14, 2022
|
Just noting: we merged this CI test before merging the PRs that would allow it to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added HLSL validation via FXC to CI since
wgpucurrently uses FXC for the D3D backends.There are 4 issues with our current tests/backend that have to be resolved for FXC validation to succeed.