Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spv-in] Add MultiView to SUPPORTED_CAPABILITIES #1934

Merged
merged 3 commits into from
May 22, 2022
Merged

[spv-in] Add MultiView to SUPPORTED_CAPABILITIES #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b5963
Add MultiView to SUPPORTED_CAPABILITIES
expenses May 20, 2022
0aaf5ee
Run cargo fmt
expenses May 20, 2022
00ec360
Fix a broken clippy lint
expenses May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/back/msl/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,8 @@ impl<W: Write> Writer<W> {
}

/// Finishes writing and returns the output.
// See https://github.com/rust-lang/rust-clippy/issues/4979.
#[allow(clippy::missing_const_for_fn)]
pub fn finish(self) -> W {
self.out
}
Expand Down
2 changes: 2 additions & 0 deletions src/back/wgsl/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,6 +1859,8 @@ impl<W: Write> Writer<W> {
Ok(())
}

// See https://github.com/rust-lang/rust-clippy/issues/4979.
#[allow(clippy::missing_const_for_fn)]
pub fn finish(self) -> W {
self.out
}
Expand Down
1 change: 1 addition & 0 deletions src/front/spv/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ pub const SUPPORTED_CAPABILITIES: &[spirv::Capability] = &[
spirv::Capability::Float16,
spirv::Capability::Float64,
spirv::Capability::Geometry,
spirv::Capability::MultiView,
// tricky ones
spirv::Capability::UniformBufferArrayDynamicIndexing,
spirv::Capability::StorageBufferArrayDynamicIndexing,
Expand Down
4 changes: 2 additions & 2 deletions src/front/wgsl/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,8 +1193,8 @@ impl Composition {
#[derive(Default)]
struct TypeAttributes {
// Although WGSL nas no type attributes at the moment, it had them in the past
// (`[[stride]]`) and may as well acquire some again in the future.
// Therefore, we are leaving the plumbing in for now.
// (`[[stride]]`) and may as well acquire some again in the future.
// Therefore, we are leaving the plumbing in for now.
}

#[derive(Clone, Debug, PartialEq)]
Expand Down