Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make termcolor dependency optional #2014

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Make termcolor dependency optional #2014

merged 1 commit into from
Jul 23, 2022

Conversation

AldaronLau
Copy link
Contributor

Termcolor only needs to be pulled in to the dependencies when codespan-reporting is pulled in.

cwfitzgerald
cwfitzgerald approved these changes Jul 23, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool beans

@cwfitzgerald cwfitzgerald merged commit a005821 into gfx-rs:master Jul 23, 2022
@AldaronLau AldaronLau deleted the optional-termcolor branch July 23, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AldaronLau @cwfitzgerald