Add ValidationFlags::BINDINGS

src/lib.rs

@@ -192,6 +192,7 @@ tree.
     clippy::unneeded_field_pattern,
     clippy::match_like_matches_macro,
     clippy::if_same_then_else,
+    clippy::collapsible_if,
     clippy::derive_partial_eq_without_eq
 )]
 #![warn(

src/valid/interface.rs

@@ -102,6 +102,7 @@ fn storage_usage(access: crate::StorageAccess) -> GlobalUse {
 struct VaryingContext<'a> {
     stage: crate::ShaderStage,
     output: bool,
+    flags: super::ValidationFlags,
     types: &'a UniqueArena<crate::Type>,
     type_info: &'a Vec<super::r#type::TypeInfo>,
     location_mask: &'a mut BitSet,
@@ -284,7 +285,10 @@ impl VaryingContext<'_> {
                     return Err(VaryingError::NotIOShareableType(ty));
                 }
                 if !self.location_mask.insert(location as usize) {
-                    return Err(VaryingError::BindingCollision { location });
+                    #[cfg(feature = "validate")]
+                    if self.flags.contains(super::ValidationFlags::BINDINGS) {
+                        return Err(VaryingError::BindingCollision { location });
+                    }
                 }
 
                 let needs_interpolation = match self.stage {
@@ -335,9 +339,15 @@ impl VaryingContext<'_> {
                         for (index, member) in members.iter().enumerate() {
                             let span_context = self.types.get_span_context(ty);
                             match member.binding {
-                                None => {
-                                    return Err(VaryingError::MemberMissingBinding(index as u32)
-                                        .with_span_context(span_context))
+                                None =>
+                                {
+                                    #[cfg(feature = "validate")]
+                                    if self.flags.contains(super::ValidationFlags::BINDINGS) {
+                                        return Err(VaryingError::MemberMissingBinding(
+                                            index as u32,
+                                        )
+                                        .with_span_context(span_context));
+                                    }
                                 }
                                 // TODO: shouldn't this be validate?
                                 Some(ref binding) => self
@@ -346,7 +356,13 @@ impl VaryingContext<'_> {
                             }
                         }
                     }
-                    _ => return Err(VaryingError::MissingBinding.with_span()),
+                    _ =>
+                    {
+                        #[cfg(feature = "validate")]
+                        if self.flags.contains(super::ValidationFlags::BINDINGS) {
+                            return Err(VaryingError::MissingBinding.with_span());
+                        }
+                    }
                 }
                 Ok(())
             }
@@ -441,7 +457,9 @@ impl super::Validator {
         }
 
         if is_resource != var.binding.is_some() {
-            return Err(GlobalVariableError::InvalidBinding);
+            if self.flags.contains(super::ValidationFlags::BINDINGS) {
+                return Err(GlobalVariableError::InvalidBinding);
+            }
         }
 
         Ok(())
@@ -497,6 +515,7 @@ impl super::Validator {
             let mut ctx = VaryingContext {
                 stage: ep.stage,
                 output: false,
+                flags: self.flags,
                 types: &module.types,
                 type_info: &self.types,
                 location_mask: &mut self.location_mask,
@@ -513,6 +532,7 @@ impl super::Validator {
             let mut ctx = VaryingContext {
                 stage: ep.stage,
                 output: true,
+                flags: self.flags,
                 types: &module.types,
                 type_info: &self.types,
                 location_mask: &mut self.location_mask,
@@ -571,8 +591,10 @@ impl super::Validator {
                     self.bind_group_masks.push(BitSet::new());
                 }
                 if !self.bind_group_masks[bind.group as usize].insert(bind.binding as usize) {
-                    return Err(EntryPointError::BindingCollision(var_handle)
-                        .with_span_handle(var_handle, &module.global_variables));
+                    if self.flags.contains(super::ValidationFlags::BINDINGS) {
+                        return Err(EntryPointError::BindingCollision(var_handle)
+                            .with_span_handle(var_handle, &module.global_variables));
+                    }
                 }
             }
         }

src/valid/mod.rs

@@ -66,6 +66,9 @@ bitflags::bitflags! {
         /// Constants.
         #[cfg(feature = "validate")]
         const CONSTANTS = 0x10;
+        /// Group, binding, and location attributes.
+        #[cfg(feature = "validate")]
+        const BINDINGS = 0x20;
     }
 }
 

tests/out/analysis/collatz.info.ron

@@ -2,7 +2,7 @@
     functions: [
         (
             flags: (
-                bits: 31,
+                bits: 63,
             ),
             available_stages: (
                 bits: 7,
@@ -346,7 +346,7 @@
     entry_points: [
         (
             flags: (
-                bits: 31,
+                bits: 63,
             ),
             available_stages: (
                 bits: 7,

tests/out/analysis/shadow.info.ron

@@ -2,7 +2,7 @@
     functions: [
         (
             flags: (
-                bits: 31,
+                bits: 63,
             ),
             available_stages: (
                 bits: 7,
@@ -1068,7 +1068,7 @@
         ),
         (
             flags: (
-                bits: 31,
+                bits: 63,
             ),
             available_stages: (
                 bits: 7,
@@ -2871,7 +2871,7 @@
     entry_points: [
         (
             flags: (
-                bits: 31,
+                bits: 63,
             ),
             available_stages: (
                 bits: 7,