Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glsl-out] use fma polyfill for versions below gles 320 #2197

Merged
merged 1 commit into from
Jan 7, 2023
Merged

[glsl-out] use fma polyfill for versions below gles 320 #2197

merged 1 commit into from
Jan 7, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jan 6, 2023 •
edited
Loading

The issue was that we were effectively requiring GLSL 310 + GL_EXT_gpu_shader5 when we could have instead used the polyfill.

Was previously brought up in #1580 (comment).
Closes #2196.

jimblandy
jimblandy approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jimblandy jimblandy merged commit 5b4e946 into gfx-rs:master Jan 7, 2023
@teoxoy teoxoy deleted the rem-fma-feat branch January 7, 2023 01:49
@teoxoy teoxoy mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

`GL_EXT_gpu_shader5' unsupported
2 participants
@teoxoy @jimblandy