spv-in: Don't apply interpolation to fragment shaders outputs #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIR-V doesn't allow the `Flat`, `NoPerspective`, `Sample` or `Centroid` decorations on fragment shaders outputs, but the spirv frontend was applying default interpolation to all outputs unconditionally. This wasn't an issue for most shaders since they output floats and the default values for them don't interfere with SPIR-V semantics, but if the shader returned a uint or int the interpolation would be set to `Flat` which as stated above is disallowed. This commit fixes the issue by only running the default interpolation code when constructing the entry point and if the stage/IO allow it.
JCapucho
force-pushed
the
spv-interpolation-fix
branch
from
ac48325 to
596ab17
Compare
teoxoy
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V doesn't allow the
Flat,NoPerspective,SampleorCentroiddecorations on fragment shaders outputs (VUID-StandaloneSpirv-Flat-06201), but the spirv frontend was applying default interpolation to all outputs unconditionally.This wasn't an issue for most shaders since they output floats and the default values for them don't interfere with SPIR-V semantics, but if the shader returned a uint or int the interpolation would be set to
Flatwhich as stated above is disallowed.This commit fixes the issue by only running the default interpolation code when constructing the entry point and if the stage/IO allow it.