[glsl/hlsl-out] Write sizes of arrays behind pointers in function arguments

[pluiedev]

Arrays can be put behind pointers in inout and out parameters in GLSL and HLSL, whose dimensions must be specified to let array access compile. So, we specify their dimensions.

Fixes #2248

[codecov-commenter]

Codecov Report

Merging #2250 (618834b) into master (1ad47f7) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2250      +/-   ##
==========================================
- Coverage   82.26%   82.01%   -0.26%     
==========================================
  Files          80       80              
  Lines       42927    43156     +229     
==========================================
+ Hits        35316    35396      +80     
- Misses       7611     7760     +149     

Impacted Files	Coverage Δ
src/back/glsl/mod.rs	86.12% <100.00%> (+0.29%)	⬆️
src/front/wgsl/parse/mod.rs	88.28% <0.00%> (-7.79%)	⬇️
src/valid/interface.rs	77.01% <0.00%> (-1.76%)	⬇️
src/front/glsl/context.rs	92.00% <0.00%> (ø)
src/valid/mod.rs	82.90% <0.00%> (+0.70%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jimblandy]

This looks fine, but it needs test coverage. There should be something in tests/in/access.wgsl that could be adapted to cover this.

[pluiedev]

I'm trying to write a test now, but dealing with pointers to arrays is a bit annoying in WGSL... gimme a bit

[pluiedev]

Yikes.. looks like HLSL has the same bug??!

void assign_array_through_ptr_fn(inout float4 foo_2)
{
    foo_2 = Constructarray2_float4_((1.0).xxxx, (2.0).xxxx);
    return;
}

[numthreads(1, 1, 1)]
void assign_through_ptr(uint3 __global_invocation_id : SV_DispatchThreadID)
{
    if (all(__global_invocation_id == uint3(0u, 0u, 0u))) {
        val = (uint)0;
    }
    GroupMemoryBarrierWithGroupSync();
    float4 arr[2] = (float4[2])0;

    arr = Constructarray2_float4_((6.0).xxxx, (7.0).xxxx);
    assign_through_ptr_fn(val);
    assign_array_through_ptr_fn(arr);
    return;
}

[jimblandy]

Thanks!